Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some typing #18

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Add some typing #18

merged 2 commits into from
Jun 24, 2022

Conversation

dstansby
Copy link
Member

Whilst I was trying to understand some of this code for cellfinder-napari purposes, I went through and added some typing. Hopefully this improves the documentation and makes some of the code clearer.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #18 (0473562) into master (0a2a6da) will decrease coverage by 0.62%.
The diff coverage is 26.92%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   37.86%   37.24%   -0.63%     
==========================================
  Files          12       12              
  Lines         272      290      +18     
==========================================
+ Hits          103      108       +5     
- Misses        169      182      +13     
Impacted Files Coverage Δ
brainglobe_napari_io/brainreg/reader_dir.py 0.00% <0.00%> (ø)
...be_napari_io/brainreg/reader_dir_standard_space.py 0.00% <0.00%> (ø)
brainglobe_napari_io/brainreg/utils.py 0.00% <0.00%> (ø)
brainglobe_napari_io/cellfinder/reader_dir.py 0.00% <0.00%> (ø)
brainglobe_napari_io/cellfinder/utils.py 88.09% <100.00%> (+1.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2a6da...0473562. Read the comment docs.

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/brainglobe/brainglobe-napari-io/18
Created: 2022-06-24T12:11:18.747133

@dstansby dstansby marked this pull request as ready for review June 24, 2022 12:20
@dstansby dstansby requested a review from a team June 24, 2022 12:20
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alessandrofelder alessandrofelder merged commit 547d6d1 into brainglobe:master Jun 24, 2022
@dstansby dstansby deleted the add-typing branch June 24, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants