Updating pbar and a couple other things #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vigji opened a cleaner PR here, if the tests pass we can merge? |
|
I've decided not to include pycln at the end because it would sometimes not work nicely with the other pre-commit checks and it was more bother than benefit... |
vigji
approved these changes
Oct 7, 2020
|
It seems that the linting is failing, but both black and flake8 pass on my machine. |
|
uhm, trying updating black? I was also having something funny with
black-ing of that file...
…On Wed, 7 Oct 2020 at 13:54, Federico Claudi ***@***.***> wrote:
It seems that the linting is failing, but both black and flake8 pass on my
machine.
Any idea how to fix?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACPLDVBQRC75AF3DAPK2JQTSJRJHBANCNFSM4SHF4HKQ>
.
|
|
Yeah, I think it's a black version issue. We should probably update the version in |
|
Done, now black did some stuff to list_atlases, le's see if that fixed it |
|
That fixed it, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.