Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .brainglobe dir if it doesn't exist when fetching atlas versions #402

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Currently, if get_atlases_last_versions is called and the .brainglobe directory doesn't exist the program will throw a FileNotFoundError.

What does this PR do?
If the .brainglobe directory doesn't exist, create it before trying to cache last_versions.conf file.

@IgorTatarnikov IgorTatarnikov requested a review from a team September 3, 2024 14:46
Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we merge this, then release, and re-run the brainreg tests?

@adamltyson adamltyson merged commit 414b0fa into main Sep 3, 2024
13 checks passed
@adamltyson adamltyson deleted the init-brainglobe-dir branch September 3, 2024 14:59
@IgorTatarnikov
Copy link
Member Author

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants