Added praire vole atlas #336
Conversation
for more information, see https://pre-commit.ci
| ATLAS_BASE_URL = "https://ndownloader.figshare.com/files/" | ||
| ORIENTATION = "..." | ||
| ROOT_ID = 997 | ||
| ATLAS_PACKAGER = "..." |
|
|
||
|
|
||
| def create_atlas(working_dir): | ||
| ATLAS_NAME = "..." |
There was a problem hiding this comment.
I've emailed the lab that originally made this atlas to see if they have a preference for the name, but for now it can just be prairie_vole_brain.
|
|
||
| def create_atlas(working_dir): | ||
| ATLAS_NAME = "..." | ||
| SPECIES = "..." |
There was a problem hiding this comment.
This can be Microtus ochrogaster
| def create_atlas(working_dir): | ||
| ATLAS_NAME = "..." | ||
| SPECIES = "..." | ||
| ATLAS_LINK = "https://elifesciences.org/articles/87029#data" |
There was a problem hiding this comment.
This can be Gustison et al. 2024, https://doi.org/10.7554/eLife.87029
| ATLAS_LINK = "https://elifesciences.org/articles/87029#data" | ||
| CITATION = "..." | ||
| ATLAS_BASE_URL = "https://ndownloader.figshare.com/files/" | ||
| ORIENTATION = "..." |
There was a problem hiding this comment.
This is the orientation of the raw data (before packaging), and should be asr. Details here if you're interested.
| ) | ||
|
|
||
| with zipfile.ZipFile( | ||
| r"C:\Users\sacha\Downloads\atlas shit\PrV_results_datasets.zip", "r" |
There was a problem hiding this comment.
This should be a relative path, defined by Pathlib so it will work on any system, e.g. atlas_path / "PrV_results_datasets.zip"
| decimate_fraction = 0.2 | ||
| smooth = False # smooth meshes after creation | ||
| start = time.time() | ||
| if PARALLEL: |
There was a problem hiding this comment.
Our parallel mesh extraction is broken, so all of this part can be removed, and just keep the stuff after else:.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Thanks @sacha091, this runs well now on my machine. The atlas looks ok, but the main issue is that there seems to be some meshes missing in the packaged atlas. There are 876 structures in |
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
What does this PR do?
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.
Checklist: