Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing kim dev atlases #304

Merged
merged 12 commits into from
Jun 3, 2024
Merged

fixing kim dev atlases #304

merged 12 commits into from
Jun 3, 2024

Conversation

viktorpm
Copy link
Contributor

@viktorpm viktorpm commented May 21, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

The kim_dev atlases fail one of our validation functions as the mesh and the annotations layers don't overlap.

What does this PR do?

References

Fixes #303

How has this PR been tested?

Atlases were regenerated and checked visually

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@viktorpm viktorpm changed the title removing annotation rotation fixing kim dev atlases May 21, 2024
@viktorpm viktorpm self-assigned this May 21, 2024
@viktorpm
Copy link
Contributor Author

Orientation looks OK (root mesh only)

image

@viktorpm viktorpm marked this pull request as ready for review June 3, 2024 10:36
@viktorpm viktorpm requested a review from alessandrofelder June 3, 2024 10:36
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable, and so do the generated atlases.

Opened #307 (which is separate to the issues addressed in this PR, and existed previously) as a possible small enhancement (thoughts welcome).

I'll let you upload the new versions @viktorpm - thank you!

@alessandrofelder alessandrofelder merged commit b4ad2b2 into main Jun 3, 2024
10 of 11 checks passed
@alessandrofelder alessandrofelder deleted the fixing_kim_dev branch June 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Kim developmental atlases fail validation
2 participants