Return "Outside atlas" rather than key error #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamltyson
changed the title
alessandrofelder
approved these changes
May 17, 2024
tests/atlasapi/test_core_atlas.py
Outdated
| @@ -102,6 +102,22 @@ def test_data_from_coords(atlas, coords): | |||
| ) | |||
|
|
|||
|
|
|||
| def test_data_from_coords_out_of_brain( | |||
| atlas, coords=(1, 1, 1), key_error_string="Outside atlas" | |||
There was a problem hiding this comment.
What's the reason for coords and key_error_string to be arguments of the test function?
I think they should just be defined in the test function body?
There was a problem hiding this comment.
No reason. I think I usually do it so anything that may need to be changed is at the top of the function. Will move it into the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
When querying for structures as ID from coordinates, out of bounds coordinates return 0, but when asking for an acronym, it raises a KeyError value.
What does this PR do?
Rather than a key error, "Outside atlas" is returned
References
Closes #157
How has this PR been tested?
New tests added & checked manually
Is this a breaking change?
Nope
Does this PR require an update to the documentation?
Don't think so
Checklist: