Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove load_labelled_volume #257

Merged
merged 4 commits into from
Mar 19, 2024
Merged

remove load_labelled_volume #257

merged 4 commits into from
Mar 19, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Mar 18, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We have a circular dependency (and can therefore not publish to conda-forge)

What does this PR do?
Removes brainglobe-utils dependent code (which was unused in this package or this org).

References

Closes #256

How has this PR been tested?

Local and CI pytest.
Searched for the removed function across the BrainGlobe GH organisation - it isn't used in not-archived repos.

Is this a breaking change?

Yes, if there are packages outside BrainGlobe depending on the load_labelled_volume, they will need to switch to the load_any function

Does this PR require an update to the documentation?

I am hoping it's sufficient we document image_io.load_any well (which we do!) and use that as our default nrrd file loader.

Checklist:

  • The code has been tested locally
  • [N/A] Tests have been added to cover all new functionality (unit & integration)
  • [N/A] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Mar 18, 2024
@alessandrofelder alessandrofelder marked this pull request as ready for review March 18, 2024 17:53
Copy link
Collaborator

@willGraham01 willGraham01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need a new release to PyPI, which I'll publish after merging this in.

The minor version bump should go trickle through to the rest of the tool-suite automatically (the meta-package should take the most recent version), but it's probably worth pinning any of our packages that depend on atlasapi from below the next time they have a PR merged in.

@willGraham01 willGraham01 merged commit bf102ad into main Mar 19, 2024
8 checks passed
@willGraham01 willGraham01 deleted the no-utils-dependency branch March 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] avoid depending on brainglobe-utils
2 participants