fix metadata key #255
Merged
fix metadata key #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K-Meech
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
metadata("brainglobe-atlasapi")["Author"]was previously returningNonebecause the key does not exist.What does this PR do?
Replaces the
metadatakey with "Author-email" key, which does exist in the package metadata. This fix is purely based on empirical inspecting of the keys returned bymetadata("brainglobe-atlasapi").References
Closes #254
How has this PR been tested?
Local installation of this fixes the
brainglobe-utilstests run in an environment with both[dev]and[napari]optional dependencies install.Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: