Fixing princeton_mouse atlas mesh #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorpm
changed the title
|
Orientation is fixed:
|
|
Mesh scaling is fixed:
|
alessandrofelder
approved these changes
Mar 11, 2024
brainglobe_atlasapi/atlas_generation/atlas_scripts/princeton_mouse.py
Outdated
Show resolved
Hide resolved
| @@ -232,6 +232,7 @@ def add_parent_id(child_id): | |||
| hemispheres_stack=None, | |||
| cleanup_files=False, | |||
| compress=True, | |||
| scale_meshes=True, | |||
was commented out and a relic of former brainrender issues
|
Shall we package and release this update, or are there others coming? |
|
Yes, @viktorpm 's next step is package and release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The size and orientation of the
princeton_mouse_20umatlas mesh are incorrect. This PR fixes it.What is this PR
References
fixes #251
How has this PR been tested?
NapariIs this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: