Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken link in the add atlas readme. #252

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Fixed broken link in the add atlas readme. #252

merged 4 commits into from
Mar 5, 2024

Conversation

PolarBean
Copy link
Contributor

Just fixing a broken link in the readme

What is this PR

  • [X ] Bug fix
  • Addition of a new feature
  • Other

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

I checked the new link and it works :)

Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PolarBean!

@adamltyson adamltyson self-requested a review March 5, 2024 13:18
@@ -31,7 +31,7 @@ A number of atlases are in development, but those available currently are:
- [Gubra's LSFM mouse brain atlas](https://doi.org/10.1007/s12021-020-09490-8) at 20 micron resolution
- [3D version of the Allen mouse spinal cord atlas](https://doi.org/10.1101/2021.05.06.443008) at 20 x 10 x 10 micron resolution
- [AZBA: A 3D Adult Zebrafish Brain Atlas](https://doi.org/10.1101/2021.05.04.442625) at 4 micron resolution
- [Waxholm Space atlas of the Sprague Dawley rat brain](https://doi.org/10.1016/j.neuroimage.2014.04.001) at 39 micron resolution
- [Waxholm Space atlas of the Sprague Dawley rat brain](https://doi.org/10.1038/s41592-023-02034-3) at 39 micron resolution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PolarBean can I check that this new reference is the most appropriate one for the version of the atlas that we have in BrainGlobe? See #215 for context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats is fair enough, I agree the updated citation would be more appropriate once you have the 4.01. that being said the newest publication is more similar to 4.0 than is Papp 2014.

adamltyson added a commit to brainglobe/brainglobe.github.io that referenced this pull request Mar 5, 2024
@adamltyson adamltyson merged commit e5296d7 into brainglobe:main Mar 5, 2024
9 of 10 checks passed
@PolarBean PolarBean deleted the patch-1 branch March 6, 2024 14:11
alessandrofelder pushed a commit to brainglobe/brainglobe.github.io that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants