Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the - in requirements #124

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Fix the - in requirements #124

merged 1 commit into from
Jun 24, 2022

Conversation

paddyroddy
Copy link
Contributor

This currently breaks pip install -e .[dev]

@paddyroddy paddyroddy added the bug Something isn't working label Jun 23, 2022
@paddyroddy paddyroddy requested a review from adamltyson June 23, 2022 12:36
@paddyroddy paddyroddy self-assigned this Jun 23, 2022
@adamltyson
Copy link
Member

This seems to have been introduced in #122, so I guess it was caused by one of the autoformatting tools.

@paddyroddy
Copy link
Contributor Author

This seems to have been introduced in #122, so I guess it was caused by one of the autoformatting tools.

I've just ran pre-commit and nothing changed

@paddyroddy
Copy link
Contributor Author

My guess would be a find all and replace in an IDE and not realising what it changed. I've done this before

@alessandrofelder alessandrofelder merged commit 59713b3 into master Jun 24, 2022
@alessandrofelder alessandrofelder deleted the fix-requirements-dev branch June 24, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamltyson adamltyson adamltyson approved these changes

Assignees

@paddyroddy paddyroddy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paddyroddy @adamltyson @alessandrofelder