Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this updates the form_themes supported keyword to replace the form.resources keyword #362

Merged

Conversation

cordoval
Copy link
Contributor

Q A
Bug Fix? n
New Feature? n
BC Breaks? n
Deprecations? n
Tests Pass? n
Fixed Tickets not reported
License MIT
Doc PR none

This fixes the deprecated warning on symfony2.7 projects. It is also fully compatible backwards since the extension in twig will define the former parameters as well just in case.

@cordoval
Copy link
Contributor Author

related symfony/symfony#14305

@cordoval
Copy link
Contributor Author

related symfony/symfony#14321 (comment)

@sstok
Copy link

sstok commented Apr 15, 2015

👍

@florianeckerstorfer ping

florianeckerstorfer pushed a commit that referenced this pull request Apr 15, 2015
Use form_themes option for auto Twig configuration
@florianeckerstorfer florianeckerstorfer merged commit 8429243 into braincrafted:master Apr 15, 2015
@florianeckerstorfer
Copy link
Member

Thanks.

@florianeckerstorfer
Copy link
Member

Uh, I was a little bit too quick. You need to create this PR against the develop branch.

@cordoval
Copy link
Contributor Author

no @florianeckerstorfer, it is ok, #364 is there for merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants