You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As the "-error" suffix was changed in BS 3.0 in favour of "-danger", shouldn't the helper method "FlashMessage::error()" be renamed (or aliased) as "FlashMessage::danger()"? Given that in Twig the convention used for , e.g., labels is "label_danger()", it seems a bit counterintuitive.
An adition like
\\ Braincrafted\Bundle\BootstrapBundle\Session\FlashMessage.php
...
/**
* Sets a danger message.
* Conforms with Bootstrap 3 suffix.
*
* @param string $message The message
*
* @return void
*/
public function danger($message)
{
$this->error($message);
}
...
should do the trick as an alias, but maybe something deeper would be required for a long term change.
The text was updated successfully, but these errors were encountered:
ManoelLobo
changed the title
FlashMessage helper method "error()" shouldn't be named "danger()"?
Shouldn't FlashMessage helper method "error()" be named "danger()"?
Oct 22, 2014
As the "-error" suffix was changed in BS 3.0 in favour of "-danger", shouldn't the helper method "FlashMessage::error()" be renamed (or aliased) as "FlashMessage::danger()"? Given that in Twig the convention used for , e.g., labels is "label_danger()", it seems a bit counterintuitive.
An adition like
should do the trick as an alias, but maybe something deeper would be required for a long term change.
The text was updated successfully, but these errors were encountered: