Issue with "has-error" class on <form> element

[althaus]

Hey,

I stumbled upon an issue with the form (error) rendering. This code snippet in the form_start Twig block leads to bad form error rendering:

{% block form_start %}
    {% spaceless %}
        ...
        {% if form.vars.errors|length > 0 %}
            {% set attr = attr|merge({ 'class': (attr.class|default('') ~ ' has-error')|trim }) %}
        {% endif %}

https://github.com/braincrafted/bootstrap-bundle/blob/develop/Resources/views/Form/bootstrap.html.twig#L739

The result is that all children are rendered as they have errors themselves, because the CSS from Bootstrap is simply

.has-error .help-block, ... {
    color: #a94442;
}

I don't know if there's a reason behind adding that class to the form root as Bootstrap hasn't anything about that in their docs. I fixed this by overriding the Twig block and renaming the error class there.

Cheers
Matthias

[sandello-alkr]

#214 (comment)

[althaus]

@sandello-alkr Cheers for the tip.

I'm still convinced that the current (out-of-the-box) implementation isn't a good one. Adding has-error to the <form> just renders all form fields as erroneous. Don't think that's something you'd like to have when you're using global errors.

My situation:
I've got some complex custom constraints targeting a whole class. Validations are added at global level. Mixing those with regular property based ones, leads to an unusable user feedback... as everything is just red. :[

[tlfbrito]

Any progress on this?