-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: coroutines, still experimental but useable #724
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mishura4
force-pushed
the
coroutines_pr
branch
5 times, most recently
from
July 11, 2023 02:59
ddbd176
to
64a4baf
Compare
Need to keep tweaking the docs, especially formatting, which I will do within the next few days |
Mishura4
changed the title
feat: coroutines, now useable
feat: coroutines, still experimental but useable
Jul 11, 2023
Mishura4
force-pushed
the
coroutines_pr
branch
4 times, most recently
from
July 15, 2023 00:05
c7aeb05
to
0a0192d
Compare
Mishura4
force-pushed
the
coroutines_pr
branch
5 times, most recently
from
July 16, 2023 04:48
b56918c
to
864ee00
Compare
👍 |
…, support destroyed awaitable on API response, fix potential race condition between task and promise destructors
braindigitalis
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's here! The rewrite of DPP's coroutines. Now supports :
co_await dpp::awaitable{interaction, &dpp::interaction_create_t::get_original_response};
co_await dpp::awaitable<http_request_completion_t>{[&](auto &&callback) { cluster->request(url, method, callback, postdata, mimetype, headers); }};
Example :
Output:
✅Thoroughly tested on MSVC 19.37.32705 and g++ 13.1, works like a charm, no leaks, no crashes during intended usage.
⚠NOT tested on clang. Currently coroutines are still labelled as "experimental" on clang, and require using libc++. If anyone wants to test it, that would be really appreciated.