Adding InlineStrings
and conversion semantics for NamedAtom
structs
#146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
NamedAtom
struct was defined like such:We used an
NTuple{8,Char}
to store a fixed-length C string so thatNamedAtom
can remain a bits type, and then overloadedBase.getproperty()
and the constructors to deal with the fact that we want to treat the fixed string data as a Julia string. However, the InlineStrings.jl package defines fixed-length strings as their own data type, with all other Julia string operations supported, so this should significantly simplify the code. I've also allowed the name field to hold up to 15 characters, an improvement from the previous 8.On top of that, I've included conversion semantics for
NamedAtom
structs, allowing them to be converted to strings or numbers easily.