dicarlo.Seibert2019

[jjpr-mit]

No description provided.

[mschrimpf]

please add unit tests -- see e.g. https://github.com/brain-score/brainio_collection/pull/37/files,

brainio_collection/tests/test_assemblies.py

Lines 171 to 179 in 6b3e901

	def test_klab_Zhang2018search():
	assembly = brainio_collection.get_assembly('klab.Zhang2018search_obj_array')
	assert set(assembly.dims) == {'presentation', 'fixation', 'position'}
	assert len(assembly['presentation']) == 4500
	assert len(set(assembly['image_id'].values)) == 300
	assert len(set(assembly['subjects'].values)) == 15
	assert len(assembly['fixation']) == 8
	assert len(assembly['position']) == 2
	assert assembly.stimulus_set is not None

, and

brainio_collection/tests/test_stimuli.py

Lines 67 to 82 in 6b3e901

	def test_klab_Zhang2018search():
	stimulus_set = brainio_collection.get_stimulus_set('klab.Zhang2018.search_obj_array')
	# There are 300 presentation images in the assembly but 606 in the StimulusSet (explanation from @shashikg follows).
	# For each of the visual search task out of total 300, you need two images (one - the target image,
	# second - the search space image) plus there are 6 different mask images to mask objects
	# present at 6 different locations in a specified search image.
	# Therefore, a total of 300 * 2 + 6 images are there in the stimulus set.
	assert len(stimulus_set) == 606
	assert len(set(stimulus_set['image_id'])) == 606
	@pytest.mark.private_access
	def test_feifei_Deng2009():
	stimulus_set = brainio_collection.get_stimulus_set('fei-fei.Deng2009')
	assert len(stimulus_set) == 50_000
	assert len(set(stimulus_set['label'])) == 1_000

[mschrimpf]

@jjpr-mit if you also add the stimulus_set test(s) and make sure they pass, I think we're good!

[jjpr-mit]

@jjpr-mit if you also add the stimulus_set test(s) and make sure they pass, I think we're good!

There's no new StimulusSet. It's HvM.