Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with vertical-position #92

Closed
bertfrees opened this issue Dec 4, 2018 · 2 comments
Closed

Issue with vertical-position #92

bertfrees opened this issue Dec 4, 2018 · 2 comments

Comments

@bertfrees
Copy link
Collaborator

bertfrees commented Dec 4, 2018 •
edited
Loading

vertical-position does not work in this situation:

<obfl xmlns="http://www.daisy.org/ns/2011/obfl" version="2011-1" xml:lang="und">
  <layout-master name="master" page-width="10" page-height="20">
    <default-template>
      <header/>
      <footer/>
    </default-template>
  </layout-master>
  <sequence master="master">
    <!-- <block>⠿⠿⠿</block> -->
    <block>
      <block vertical-position="4">⠿⠿⠿</block>
      <block vertical-position="8">⠿⠿⠿</block>
    </block>
  </sequence>
</obfl>

The vertical-position="8" works, but the vertical-position="4" not. When the first block is uncommented, it works. And it also works when the outer block containing the two other is removed.
@bertfrees
Copy link
Collaborator Author

After updating to the latest Dotify this is now also an issue for SBS.

bertfrees added a commit to sbsdev/pipeline that referenced this issue Jan 15, 2019
@bertfrees
[sbs] Update to latest Pipeline snapshots
257174f 
Because of regressions in Dotify some tests had to be set to xfail
some hacks had to be added to the CSS.

See brailleapps/dotify.formatter.impl#92 and
brailleapps/dotify.formatter.impl#39.
bertfrees added a commit to sbsdev/pipeline that referenced this issue Feb 11, 2019
@bertfrees
[dotify] Fix vertical-position regression
759bd1f 
see brailleapps/dotify.formatter.impl#92
@bertfrees
Copy link
Collaborator Author

bertfrees commented Feb 11, 2019 •
edited
Loading

Fixed in sbsdev/pipeline@759bd1f.

@bertfrees bertfrees mentioned this issue Mar 21, 2019
Open
bertfrees added a commit to sbsdev/dotify.formatter.impl that referenced this issue Mar 21, 2019
@bertfrees
Fix vertical-position regression
622e6dd 
see brailleapps#92
@bertfrees bertfrees mentioned this issue Mar 21, 2019
Closed
joeha480 added a commit that referenced this issue May 9, 2019
@joeha480 @bertfrees
Fix problem with vertical position (fixes #92, closes #96)
3903aae 
Co-authored-by: Bert Frees <[email protected]>
bertfrees added a commit to sbsdev/pipeline-mod-sbs that referenced this issue Jun 13, 2019
@bertfrees
[sbs] Update to latest Pipeline snapshots
642f292 
Because of regressions in Dotify some tests had to be set to xfail
some hacks had to be added to the CSS.

See brailleapps/dotify.formatter.impl#92 and
brailleapps/dotify.formatter.impl#39.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bertfrees