Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API uses of get/setFeature in embosser package #21

Open
joeha480 opened this issue Sep 13, 2018 · 0 comments
Open

Remove API uses of get/setFeature in embosser package #21

joeha480 opened this issue Sep 13, 2018 · 0 comments

Comments

@joeha480
Copy link
Contributor

The get/setFeature methods are overused in the embosser package (in fact, they are relied on for normal operation, most notably for getting/setting a Table), this is confusing for new users of the API. The Embosser interface implies that some features can be set (via various "supports"-methods), but the relationship between this interface and EmbosserFeatures is completely implicit.

The get/setFeature should remain, but only for non-API use, meaning features not defined by the API.
@joeha480 joeha480 mentioned this issue Sep 13, 2018
Closed
joeha480 pushed a commit to joeha480/braille-utils.impl that referenced this issue Jun 13, 2019
@joeha480
WIP: Provide methods for required operations
d737c6f 
This is an implementation of an unreleased change to the dotify.api
See brailleapps/dotify.api#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeha480