Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce toast usage #278

Open
2 tasks done
zuevval opened this issue Oct 3, 2020 · 7 comments · May be fixed by #279
Open
2 tasks done

reduce toast usage #278

zuevval opened this issue Oct 3, 2020 · 7 comments · May be fixed by #279
Assignees
Labels
enhancement New feature or request interface Design and navigation lessons Lessons section improvement practice Practice section improvement

Comments

@zuevval
Copy link
Member

zuevval commented Oct 3, 2020

There's a heck of toasts here and there in the app, so when I switch controls quickly, they lag severely. Now there are even more of them after introducing columns flips.

I propose a (partial) solution:

  • Instead of toasts, announce the column flip event by an accessibility service + write numbers on each dot for sighted
  • practice: replace toasts with announcements, too, + animate "next" button (red/green glow on answer)
@zuevval zuevval self-assigned this Oct 3, 2020
@zuevval zuevval added enhancement New feature or request interface Design and navigation lessons Lessons section improvement practice Practice section improvement labels Oct 3, 2020
zuevval added a commit to zuevval/learn-braille that referenced this issue Oct 3, 2020
zuevval added a commit to zuevval/learn-braille that referenced this issue Oct 3, 2020
@zuevval
Copy link
Member Author

zuevval commented Oct 3, 2020

First done. Here's how it looks like (GIF animation).
dots captions screenshot

@zuevval
Copy link
Member Author

zuevval commented Oct 3, 2020

or maybe use a thinner font? Compare:

left to right: default, Sans Serif light, Sans Serif thin.

I'd rather use Sans Serif Light

zuevval added a commit to zuevval/learn-braille that referenced this issue Oct 3, 2020
zuevval added a commit to zuevval/learn-braille that referenced this issue Oct 3, 2020
zuevval added a commit to zuevval/learn-braille that referenced this issue Oct 3, 2020
zuevval added a commit to zuevval/learn-braille that referenced this issue Oct 3, 2020
zuevval added a commit to zuevval/learn-braille that referenced this issue Oct 3, 2020
@zuevval
Copy link
Member Author

zuevval commented Oct 3, 2020

So i have thought of two options. First is to set up an animation for the "next" button:

However, it looks strange when on-the-fly checks are turned on. So I have implemented another thing - an animated background

This required unsetting the Braille dots' background with the vertical line, but I suppose it's not important because now dots have numbers.

zuevval added a commit to zuevval/learn-braille that referenced this issue Oct 3, 2020
@zuevval zuevval linked a pull request Oct 3, 2020 that will close this issue
1 task
@zuevval zuevval linked a pull request Oct 3, 2020 that will close this issue
1 task
@zuevval
Copy link
Member Author

zuevval commented Oct 3, 2020

another idea, maybe this is better?

@winter-yuki
Copy link
Member

or maybe use a thinner font? Compare:

left to right: default, Sans Serif light, Sans Serif thin.

I'd rather use Sans Serif Light

Sans Serif light looks better to me

@winter-yuki
Copy link
Member

another idea, maybe this is better?

Animating all background I like more

@zuevval
Copy link
Member Author

zuevval commented Oct 4, 2020

Animating all background I like more

@winter-yuki, I thought that animating the whole background may be unpleasant for eyes, especially after you use it for a while. Try to download the APK from the last workflow and practice for 5 minutes.

zuevval added a commit to zuevval/learn-braille that referenced this issue Oct 17, 2020
zuevval added a commit that referenced this issue Oct 17, 2020
zuevval added a commit that referenced this issue Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request interface Design and navigation lessons Lessons section improvement practice Practice section improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants