Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Add a roadmap #228

Merged
merged 11 commits into from
Dec 16, 2018
Merged

Add a roadmap #228

merged 11 commits into from
Dec 16, 2018

Conversation

j-f1
Copy link
Collaborator

@j-f1 j-f1 commented Dec 15, 2018

This adds a roadmap with a complete listing of TSLint core rules and their equivalents in the ESLint ecosystem.

Rendered Version 📄

@j-f1 j-f1 added the WIP PRs that are work in progress label Dec 15, 2018
@j-f1
Copy link
Collaborator Author

j-f1 commented Dec 15, 2018

I cross-promoted Prettier in a few of the rule listings, but I’m willing to remove it if you don’t want it there.

@j-f1
Copy link
Collaborator Author

j-f1 commented Dec 15, 2018

(Directing users to Prettier would save us from having to implement formatting rules for TS)

@armano2
Copy link
Contributor

armano2 commented Dec 15, 2018

@j-f1 eslint-plugin-import is not supporting typescript equal assign import and export assign import

import foo = require('bar') 

but besides of that, nice work 👍

@j-f1 j-f1 mentioned this pull request Dec 15, 2018
31 tasks
@j-f1
Copy link
Collaborator Author

j-f1 commented Dec 15, 2018

import-js/eslint-plugin-import#1244 @armano2

@ljharb
Copy link

ljharb commented Dec 15, 2018

Even if prettier supports formatting, it would be ideal to support it in eslint directly.

@armano2
Copy link
Contributor

armano2 commented Dec 15, 2018

@bradzacher is currently working on indent rule see #219

@armano2
Copy link
Contributor

armano2 commented Dec 16, 2018

@armano2
Copy link
Contributor

armano2 commented Dec 16, 2018

i'm going to work on interface-over-type-literal #238

Copy link
Owner

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradzacher
Copy link
Owner

bradzacher commented Dec 16, 2018

It's great for us to cross promote other packages.
The more work we can reasonably offload to existing packages the better. Love the cross promotion of packages like import.

That being said, while I do love prettier [1], due to its low configurability I think we should be cautious about not implementing things here purely because it's in prettier. Though alerting people to it as an alternative to fill our holes is a great idea.


[1] since starting at FB (where it's on by default for JS code), I've added prettier-eslint to all my personal projects. For my code I didn't quite like how prettier formatted the code, but when paired with eslint fixers it's perfect. It's literally changed my coding life.

@j-f1 j-f1 merged commit bd9f49b into master Dec 16, 2018
@j-f1 j-f1 deleted the add-roadmap branch December 16, 2018 21:35
@j-f1 j-f1 removed the WIP PRs that are work in progress label Dec 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants