Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dashboard.jsx #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Dashboard.jsx #12

wants to merge 2 commits into from

Conversation

nirg122
Copy link

@nirg122 nirg122 commented Aug 17, 2022

fixes logging out crashing the app with continuous error of "cannot get property of null (token)" in newer version of react.

@nirg122
Update Dashboard.jsx
412deed 
fixes logging out crashing the app with continuous error of "cannot get property of null (token)" in newer version of react.
@nirg122
Update Dashboard.jsx
df65923
im-ghost
im-ghost suggested changes Oct 1, 2022
View reviewed changes
Copy link

@im-ghost im-ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you get the goals after the page alr redirected to a login page

@nirg122
Copy link
Author

nirg122 commented Oct 2, 2022

Why would you get the goals after the page alr redirected to a login page

I think you read the code wrong.
I redirect only if the user is not logged in, else (if the user is logged in), I'm getting all the goals.

im-ghost
im-ghost reviewed Oct 2, 2022
View reviewed changes
Copy link

@im-ghost im-ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the other commit,my bad.

fisayo-dmg
fisayo-dmg approved these changes Oct 10, 2022
View reviewed changes
Copy link

@fisayo-dmg fisayo-dmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, noticed this bug and was about to suggest this same change.

Lukeos11
Lukeos11 approved these changes Jan 22, 2023
View reviewed changes
Copy link

@Lukeos11 Lukeos11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the same error this fixes it

ziaulkadri
ziaulkadri approved these changes Feb 9, 2023
View reviewed changes
Copy link

@ziaulkadri ziaulkadri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves mine error too

MadManMcIvor
MadManMcIvor approved these changes Feb 10, 2023
View reviewed changes
Copy link

@MadManMcIvor MadManMcIvor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent so long trying to figure out what was going on. This solved it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-ghost im-ghost im-ghost requested changes

@MadManMcIvor MadManMcIvor MadManMcIvor approved these changes

@ziaulkadri ziaulkadri ziaulkadri approved these changes

@Lukeos11 Lukeos11 Lukeos11 approved these changes

@fisayo-dmg fisayo-dmg fisayo-dmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirg122 @fisayo-dmg @Lukeos11 @im-ghost @ziaulkadri @MadManMcIvor