Prevent adding Accept header when already one. #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents the Accept header
application/vnd.github.v3+json
from being added to the headers in case there is already an Accept header.The mentioned header is necessary for most interactions with the GitHub API, but it also influence the behaviour of some resource call in an unexpected way.
Example:
When downloading a release with the go-github library, an Accept header
application/octet-stream
is added by the latter, then ghinstallation adds the Accept headerapplication/vnd.github.v3+json
.The response to such request isn't the content of the release, as one could expect when using the function
DownloadReleaseAsset
but a json describing the release.This PR prevents this behaviour from happening and tackle the issue #12