Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate dgrijalva/jwt-go to golang-jwt/jwt-go #53

Merged
merged 3 commits into from
Sep 18, 2021

Conversation

shogo82148
Copy link
Contributor

github.com/dgrijalva/jwt-go is no longer maintained.

https://github.com/dgrijalva/jwt-go#readme says:

THIS REPOSITORY IS NO LONGER MAINTANED
The new repository can be found at: https://github.com/golang-jwt/jwt

For more information, see issue #462.

it recommends to migrate to https://github.com/golang-jwt/jwt

@SVilgelm
Copy link

Fixes #54

@shogo82148
Copy link
Contributor Author

memo: Int.FillBytes was added in Go 1.15.

https://github.com/bradleyfalzon/ghinstallation/pull/53/checks?check_run_id=3582316698#step:5:12

# github.com/golang-jwt/jwt/v4
Error: ../../../go/pkg/mod/github.com/golang-jwt/jwt/[email protected]/ecdsa.go:135:4: r.FillBytes undefined (type *big.Int has no field or method FillBytes)
Error: ../../../go/pkg/mod/github.com/golang-jwt/jwt/[email protected]/ecdsa.go:136:4: s.FillBytes undefined (type *big.Int has no field or method FillBytes)
note: module requires Go 1.15

@bradleyfalzon
Copy link
Owner

@shogo82148 are you able to resolve the conflict with master? Apologies for this.

@shogo82148
Copy link
Contributor Author

@bradleyfalzon I did.

@torstenwalter
Copy link

@bradleyfalzon could you have another look?

@bradleyfalzon bradleyfalzon merged commit 6aab955 into bradleyfalzon:master Sep 18, 2021
@bradleyfalzon
Copy link
Owner

Looks good, just on mobile and will need to tag once I get near a computer

@markushinz
Copy link

@bradleyfalzon could you create new release?

@bradleyfalzon
Copy link
Owner

Apologies, released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants