Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Modules Support #28

Closed
bradleyfalzon opened this issue Sep 28, 2019 · 3 comments · Fixed by #29
Closed

Go Modules Support #28

bradleyfalzon opened this issue Sep 28, 2019 · 3 comments · Fixed by #29
Assignees

Comments

@bradleyfalzon
Copy link
Owner

As discussed in #27, and other breaking changes discussions such as #21, we should maintain our own tagging, as well as go module support for our dependencies.

Currently, tags do exist up to v0.1.2, however, since then there have been breaking changes in #21 and another proposed in #27.

Because this library is still, essentially v0, I think it may be OK to push v0.1.3 pointing to latest commit even though it would then tag a breaking change. Once #27 is resolved, and if there's no immediate list of breaking changes, v1.0.0 could be released.

Along with v0.1.3 tag, we can add Go modules commit, as I see no reason not to add that.

@bradleyfalzon
Copy link
Owner Author

@wlynch This is my first experience with Go modules, let me know if you have any thoughts/comments or alternatives.

@bradleyfalzon bradleyfalzon self-assigned this Sep 28, 2019
wlynch added a commit to wlynch/ghinstallation that referenced this issue Oct 9, 2019
See https://golang.org/doc/go1.13#modules for more details.

Also pulls in some auto-formatting changes.

Fixes bradleyfalzon#28
wlynch added a commit to wlynch/ghinstallation that referenced this issue Oct 9, 2019
See https://golang.org/doc/go1.13#modules for more details.

Also pulls in some auto-formatting changes.

Fixes bradleyfalzon#28
@wlynch
Copy link
Collaborator

wlynch commented Oct 9, 2019

This is also my first hands-on experience with go modules! Played around with it a bit and created #29 .

Modules will not actually make breaking changes any better for #27. The main benefit they provide is to pin the dependencies of ghinstallation so that if one of our dependencies makes a breaking change we (and our dependents) will be resilient to it.

As long as we continue to follow vX.X.X semver, ghinstallation should be compatible for others to use with modules within their own projects.

@bradleyfalzon
Copy link
Owner Author

bradleyfalzon commented Oct 9, 2019 via email

wlynch added a commit to wlynch/ghinstallation that referenced this issue Oct 9, 2019
See https://golang.org/doc/go1.13#modules for more details.

Also pulls in some auto-formatting changes.

Fixes bradleyfalzon#28
wlynch added a commit to wlynch/ghinstallation that referenced this issue Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants