-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Alpine Linux #37
Conversation
- Add `ALPINE_VERSION` build argument, which will be empty by default, or prefixed with a `-` if set - Use `ALPINE_VERSION` to pull Docker image: will look like `FROM python:3.9-alpine` - Use `wget`, which is included with both Debian and Alpine by default, instead of `curl`, which is not included with Alpine by default - Conditionally install build dependencies on Alpine by sourcing `/etc/os-release`, which contains `$ID` to indicate the Linux distro
Docker image tags will append `-alpine` for Alpine Linux builds: `docker pull ghcr.io/br3ndonland/inboard:fastapi-python3.8-alpine`
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/br3ndonland/inboard/8xEiD3CWvvnJK5JzASscEPwtfiC9 |
Codecov Report
@@ Coverage Diff @@
## develop #37 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 271 271
=========================================
Hits 271 271
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
#37 Build dependencies were initially left in the Alpine Linux Docker images because without them, the packages used by inboard cannot be installed or updated. However, these build dependencies also may not be adequate to build packages in downstream projects. Each project will likely need to assemble its own build dependencies. Rather than retaining build dependencies in the final Docker images, inboard will remove them after package installs, and document how to install them again for downstream projects. A subsequent commit will add documentation about how to install build dependencies on Alpine Linux.
#37 Each project will likely need to assemble its own build dependencies, so inboard will document how to install them.
Description
This PR will add support for Alpine Linux, based on the distribution provided by the official Python Docker images.
Changes
Related
tiangolo/uvicorn-gunicorn-docker#19
tiangolo/uvicorn-gunicorn-docker#22
tiangolo/uvicorn-gunicorn-docker#33
tiangolo/uvicorn-gunicorn-docker#45
tiangolo/uvicorn-gunicorn-docker#65
tiangolo/uvicorn-gunicorn-docker#72
tiangolo/uvicorn-gunicorn-fastapi-docker#18
tiangolo/uvicorn-gunicorn-fastapi-docker#31
tiangolo/uvicorn-gunicorn-fastapi-docker#53
tiangolo/uvicorn-gunicorn-fastapi-docker#61