Add inboard logo #22
Merged
Add inboard logo #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://gist.github.com/br3ndonland/d66ce3c8e98cf8bd4f3c24d006409e41 SVG images can't be uploaded within GitHub comments, so the SVG has been added to a public GitHub Gist: https://gist.github.com/br3ndonland/d66ce3c8e98cf8bd4f3c24d006409e41 A Gist is actually a Git repository with some limitations: - No subdirectories are allowed - Only code files can be uploaded from the web UI. To upload blobs like PNG files, clone the repo and commit them locally as described below. To clone a Gist: ```text git clone [email protected]:GIST_ID.git DIRECTORY_NAME ``` To use images from a Gist: - Commit the image file to the Gist repo (in the same directory) - Push the change to GitHub with `git push` - Click on the "raw" button next to the image - Copy the URL - Add the URL to an image tag in the Markdown file.
Codecov Report
@@ Coverage Diff @@
## develop #22 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 222 222
=========================================
Hits 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
br3ndonland
added a commit
that referenced
this pull request
May 16, 2021
#22 https://gist.github.com/br3ndonland/d66ce3c8e98cf8bd4f3c24d006409e41 This commit will add the inboard logo SVG to the docs directory. As described in #22, the logo was produced with Figma. Figma wasn't exporting the Gunicorn logo correctly, but it is now fixed. In Figma, the Gunicorn logo stroke was changed from inside to center, as recommended here: https://forum.figma.com/t/svg-export-issue/3424
br3ndonland
added a commit
that referenced
this pull request
May 16, 2021
#22 https://gist.github.com/br3ndonland/d66ce3c8e98cf8bd4f3c24d006409e41 This commit will add the inboard logo SVG to the docs directory. As described in #22, the logo was produced with Figma. Figma wasn't exporting the Gunicorn logo correctly, but it is now fixed. In Figma, the Gunicorn logo stroke was changed from inside to center, as recommended here: https://forum.figma.com/t/svg-export-issue/3424 The Starlette and Uvicorn logo sources are PNG. Figma base64-encodes PNG sources into SVG exports, which results in large file sizes. To reduce the size of the exported logos, they were converted to vectors with the Figma image tracer plugin. This conversion reduces the size of the inboard logo SVG by 10x (>900 kb -> 90 kb). https://www.figma.com/community/plugin/735707089415755407/Image-tracer
br3ndonland
added a commit
that referenced
this pull request
May 16, 2021
#22 https://gist.github.com/br3ndonland/d66ce3c8e98cf8bd4f3c24d006409e41 This commit will add the inboard logo SVG to the docs directory. As described in #22, the logo was produced with Figma. Figma wasn't exporting the Gunicorn logo correctly, but it is now fixed. In Figma, the Gunicorn logo stroke was changed from inside to center, as recommended here: https://forum.figma.com/t/svg-export-issue/3424 The Starlette and Uvicorn logo sources are PNG. Figma base64-encodes PNG sources into SVG exports, which results in large file sizes. To reduce the size of the exported logos, they were converted to vectors with the Figma image tracer plugin. This conversion reduces the size of the inboard logo SVG by 10x (>900 kb -> 90 kb). https://www.figma.com/community/plugin/735707089415755407/Image-tracer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add a logo for the project.
The logo was created with Figma, based on the following resources (in the order in which they are seen in the image, top to bottom):
SVG images can't be uploaded within GitHub comments, so the SVG has been added to a public GitHub Gist.
A Gist is actually a Git repository with some limitations:
To clone a Gist:
To use images from a Gist:
git pushChanges
Related