Housekeeping #192
Merged
Housekeeping #192
+2,400
−1,172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested review from
barmac,
a team and
jarekdanielak
and removed request for
a team
barmac
reviewed
Nov 15, 2024
| test: [ | ||
| 'src/test/*/*.ts' | ||
| ], | ||
| node_test: [ |
There was a problem hiding this comment.
What is unexpected there? Tests simply contain parts that are node, and parts that are client.
There was a problem hiding this comment.
(Happy to follow-up if there is stuff we can improve).
There was a problem hiding this comment.
snake_case, sorry for unclear comment
There was a problem hiding this comment.
Ok 🐍 Now I got your emoji.
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
On top of #190 this applies additional housekeeping, including migration to ESLint 9 (https://github.com/bpmn-io/internal-docs/issues/1042).
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}