Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update eslint* dependencies (major) #385

Merged
merged 6 commits into from
Oct 15, 2024
Merged

chore: update eslint* dependencies (major) #385

merged 6 commits into from
Oct 15, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 10, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) ^8.56.0 -> ^9.0.0 age adoption passing confidence
eslint-plugin-bpmn-io ^1.0.0 -> ^2.0.0 age adoption passing confidence
eslint-plugin-react-hooks (source) ^4.2.0 -> ^5.0.0 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.12.0

Compare Source

Features

Bug Fixes

Documentation

  • ecbd522 docs: Mention code explorer (#​18978) (Nicholas C. Zakas)
  • 7ea4ecc docs: Clarifying the Use of Meta Objects (#​18697) (Amaresh S M)
  • d3e4b2e docs: Clarify how to exclude .js files (#​18976) (Milos Djermanovic)
  • 57232ff docs: Mention plugin-kit in language docs (#​18973) (Nicholas C. Zakas)
  • b80ed00 docs: Update README (GitHub Actions Bot)
  • cb69ab3 docs: Update README (GitHub Actions Bot)
  • 7fb0d95 docs: Update README (GitHub Actions Bot)
  • 493348a docs: Update README (GitHub Actions Bot)
  • 87a582c docs: fix typo in id-match rule (#​18944) (Jay)

Chores

v9.11.1

Compare Source

v9.11.0

Compare Source

Features

  • ec30c73 feat: add "eslint/universal" to export Linter (#​18883) (唯然)
  • c591da6 feat: Add language to types (#​18917) (Nicholas C. Zakas)
  • 492eb8f feat: limit the name given to ImportSpecifier in id-length (#​18861) (Tanuj Kanti)
  • 19c6856 feat: Add no-useless-constructor suggestion (#​18799) (Jordan Thomson)
  • a48f8c2 feat: add type FormatterFunction, update LoadedFormatter (#​18872) (Francesco Trotta)

Bug Fixes

  • 5e5f39b fix: add missing types for no-restricted-exports rule (#​18914) (Kristóf Poduszló)
  • 8f630eb fix: add missing types for no-param-reassign options (#​18906) (Kristóf Poduszló)
  • d715781 fix: add missing types for no-extra-boolean-cast options (#​18902) (Kristóf Poduszló)
  • 2de5742 fix: add missing types for no-misleading-character-class options (#​18905) (Kristóf Poduszló)
  • c153084 fix: add missing types for no-implicit-coercion options (#​18903) (Kristóf Poduszló)
  • fa11b2e fix: add missing types for no-empty-function options (#​18901) (Kristóf Poduszló)
  • a0deed1 fix: add missing types for camelcase options (#​18897) (Kristóf Poduszló)

Documentation

  • e4e5709 docs: correct prefer-object-has-own type definition comment (#​18924) (Nitin Kumar)
  • 91cbd18 docs: add unicode abbreviations in no-irregular-whitespace rule (#​18894) (Alix Royere)
  • 59cfc0f docs: clarify resultsMeta in LoadedFormatter type (#​18881) (Milos Djermanovic)
  • adcc50d docs: Update README (GitHub Actions Bot)
  • 4edac1a docs: Update README (GitHub Actions Bot)

Build Related

  • 959d360 build: Support updates to previous major versions (#​18871) (Milos Djermanovic)

Chores

v9.10.0

Compare Source

v9.9.1

Compare Source

v9.9.0

Compare Source

Features

  • 41d0206 feat: Add support for TS config files (#​18134) (Arya Emami)
  • 3a4eaf9 feat: add suggestion to require-await to remove async keyword (#​18716) (Dave)

Documentation

  • 9fe068c docs: how to author plugins with configs that extend other configs (#​18753) (Alec Gibson)
  • 48117b2 docs: add version support page in the side navbar (#​18738) (Amaresh S M)
  • fec2951 docs: add version support page to the dropdown (#​18730) (Amaresh S M)
  • 38a0661 docs: Fix typo (#​18735) (Zaina Al Habash)
  • 3c32a9e docs: Update yarn command for creating ESLint config (#​18739) (Temitope Ogunleye)
  • f9ac978 docs: Update README (GitHub Actions Bot)

Chores

v9.8.0

Compare Source

v9.7.0

Compare Source

Features

  • 7bd9839 feat: add support for es2025 duplicate named capturing groups (#​18630) (Yosuke Ota)
  • 1381394 feat: add regex option in no-restricted-imports (#​18622) (Nitin Kumar)

Bug Fixes

  • 14e9f81 fix: destructuring in catch clause in no-unused-vars (#​18636) (Francesco Trotta)

Documentation

  • 9f416db docs: Add Powered by Algolia label to the search. (#​18633) (Amaresh S M)
  • c8d26cb docs: Open JS Foundation -> OpenJS Foundation (#​18649) (Milos Djermanovic)
  • 6e79ac7 docs: loadESLint does not support option cwd (#​18641) (Francesco Trotta)

Chores

v9.6.0

Compare Source

v9.5.0

Compare Source

v9.4.0

Compare Source

v9.3.0

Compare Source

v9.2.0

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.0

Compare Source

v8.57.1

Compare Source

v8.57.0

Compare Source

Features

  • 1120b9b feat: Add loadESLint() API method for v8 (#​18098) (Nicholas C. Zakas)
  • dca7d0f feat: Enable eslint.config.mjs and eslint.config.cjs (#​18066) (Nitin Kumar)

Bug Fixes

  • 2196d97 fix: handle absolute file paths in FlatRuleTester (#​18064) (Nitin Kumar)
  • 69dd1d1 fix: Ensure config keys are printed for config errors (#​18067) (Nitin Kumar)
  • 9852a31 fix: deep merge behavior in flat config (#​18065) (Nitin Kumar)
  • 4c7e9b0 fix: allow circular references in config (#​18056) (Milos Djermanovic)

Documentation

Chores

bpmn-io/eslint-plugin-bpmn-io (eslint-plugin-bpmn-io)

v2.0.2

Compare Source

  • FIX: fine-tune jsx rules

v2.0.1

Compare Source

  • FIX: fine-tune mocha rules (#​21)

v2.0.0

Compare Source

  • FEAT: migrate to flat config (#​19)
  • FEAT: turn into ES module
  • FEAT: base of react:recommended and mocha:recommended configs
  • DEPS: require eslint@9
Breaking Changes
  • Consume as an ES module (#​20)
  • Use alongside eslint@9 (#​20)

v1.0.1

Compare Source

facebook/react (eslint-plugin-react-hooks)

v5.0.0

Compare Source

  • New Violations: Component names now need to start with an uppercase letter instead of a non-lowercase letter. This means _Button or _component are no longer valid. (@​kassens) in #​25162

v4.6.2

Compare Source

v4.6.1

Compare Source

Configuration

📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Updates a dependency label Oct 10, 2024
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Oct 10, 2024 •
edited
Loading

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^9.0.0" from the root project
npm ERR!   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/[email protected]
npm ERR!   node_modules/@eslint-community/eslint-utils
npm ERR!     @eslint-community/eslint-utils@"^4.2.0" from [email protected]
npm ERR!   5 more (eslint-utils, eslint-plugin-bpmn-io, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8" from [email protected]
npm ERR! node_modules/eslint-plugin-import
npm ERR!   dev eslint-plugin-import@"^2.29.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8" from [email protected]
npm ERR!   node_modules/eslint-plugin-import
npm ERR!     dev eslint-plugin-import@"^2.29.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate/cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate/cache/others/npm/_logs/2024-10-11T14_12_23_679Z-debug-0.log

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 10, 2024
@jarekdanielak jarekdanielak self-assigned this Oct 11, 2024
@jarekdanielak
Copy link
Contributor

Will need to wait for eslint-plugin-react-hooks release: facebook/react#28313

@jarekdanielak jarekdanielak added backlog Queued in backlog and removed needs review Review pending labels Oct 11, 2024
@barmac barmac added ready Ready to be worked on and removed backlog Queued in backlog labels Oct 14, 2024
@barmac
Copy link
Member

barmac commented Oct 14, 2024

Unblocked: facebook/react#28313 (comment)

@renovate Renovate
Copy link
Contributor Author

renovate bot commented Oct 14, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Oct 14, 2024
barmac
barmac reviewed Oct 14, 2024
View reviewed changes
src/components/entries/FEEL/FeelPopup.js Outdated
@@ -30,7 +30,7 @@ export const FEEL_POPUP_HEIGHT = 250;
export default function FEELPopupRoot(props) {
const {
element,
eventBus = { fire() {}, on() {}, off() {} },
eventBus = { fire() { }, on() { }, off() { } },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks absurd. I think we'd rather not have a rule which enforces space here.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sneaked in from the moment I had the linter misconfigured. There is no such rule. I'll revert it.

barmac
barmac reviewed Oct 14, 2024
View reviewed changes
src/components/entries/NumberField.js Outdated
@@ -58,7 +58,7 @@ export function NumberField(props) {

return (
<div class="bio-properties-panel-numberfield">
{displayLabel && <label for={ prefixId(id) } class="bio-properties-panel-label">{ label }</label> }
{displayLabel && <label htmlFor={ prefixId(id) } class="bio-properties-panel-label">{ label }</label> }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is coming from React limitations. I'd rather adjust the rules to not enforce it as we are fine in preact world with such attributes.

@barmac
Copy link
Member

barmac commented Oct 14, 2024

I am done with the review. I'd rather reconsider the rule added in a plugin if it triggers multiple changes with no rational grounds, e.g. for vs. htmlFor. We are not doing React in this project, so we should not need to enforce react-specific rules.

@barmac
Copy link
Member

barmac commented Oct 14, 2024

There are still some places with htmlFor: #385 (comment)

@jarekdanielak jarekdanielak merged commit 7eb762d into main Oct 15, 2024
12 checks passed
@jarekdanielak jarekdanielak deleted the renovate/major-eslint branch October 15, 2024 13:42
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarekdanielak jarekdanielak jarekdanielak left review comments

@nikku nikku Awaiting requested review from nikku

@barmac barmac Awaiting requested review from barmac

Assignees

@jarekdanielak jarekdanielak

Labels
dependencies Updates a dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarekdanielak @barmac