-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain $parent
safely within the core
#41
Labels
backlog
Queued in backlog
enhancement
New feature or request
spring cleaning
Could be cleaned up one day
Comments
We had a related user request recently: bpmn-io/bpmn-moddle#92 It included an interesting discussion around this (where to maintain what, what's the expectation) => the user expected that this is maintained in the core. 👍 |
Good validation! 👍🏻 |
bpmn-io-tasks
bot
added
in progress
Currently worked on
and removed
backlog
Queued in backlog
labels
Feb 3, 2023
bpmn-io-tasks
bot
added
needs review
Review pending
in progress
Currently worked on
and removed
in progress
Currently worked on
needs review
Review pending
labels
Feb 6, 2023
bpmn-io-tasks
bot
added
in progress
Currently worked on
and removed
backlog
Queued in backlog
labels
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backlog
Queued in backlog
enhancement
New feature or request
spring cleaning
Could be cleaned up one day
Is your feature request related to a problem? Please describe
The child to parent pointer
$parent
is important for model traversal. We do have basic test coverage for it, however we do not ensure that it is being maintained as part of the core. Instead, libraries using it (i.e. moddle-xml, bpmn-js) manually maintain the property in various places. This is error prone and not properly done everywhere.At best, we do automatically maintain the property:
Describe the solution you'd like
$parent
is maintained automatically by moddle so that I can rely on itDescribe alternatives you've considered
Keep
$parent
maintenance out of scope for the library.Additional context
Brought up in the context of bpmn-io/bpmnlint#69 (comment).
The text was updated successfully, but these errors were encountered: