feat(popup): allow non-searchable entries #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
Dec 5, 2023
| @@ -77,6 +77,10 @@ export default function PopupMenuComponent(props) { | |||
| return (entry.rank || 0) >= 0; | |||
| } | |||
|
|
|||
| if (entry.searchable === false) { | |||
| return 0; | |||
There was a problem hiding this comment.
Suggested change
| return 0; | |
| return false; |
Let's keep this interface uniform. We always return a boolean.
There was a problem hiding this comment.
You're right, got momentarily confused with the 0 from above. Updated
smbea
force-pushed
the
non-serachable-popup-entries
branch
from
de4c598
to
fa6486e
Compare
nikku
approved these changes
Dec 6, 2023
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #834