Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make canvas selectable / keyboard binding implicit #662

Merged
merged 3 commits into from
Nov 4, 2024

Commits on Nov 4, 2024

  1. feat(core): make Canvas focusable

    The `Canvas` is now a focusable component, that is recognized
    accordingly by the browser, with all benefits for UX and interaction.
    
    Components that pull focus from the `Canvas` during modeling must
    ensure to restore the focus (if intended), via `Canvas#restoreFocus`.
    
    Related to #661
    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    670428a View commit details
    Browse the repository at this point in the history
  2. feat(keyboard): make keyboard binding implicit

    Keyboard is now implicitly bound to the canvas element (svg).
    
    Legacy configuration via `keyboard.bindTo` config or by passing an element
    to `Keyboard#bind()` results in a descriptive error to be raised.
    
    BREAKING CHANGES:
    
    * Keyboard is now implicitly bound to the (focusable) canvas parent.
      Prior usages result in human readable errors to be raised.
    nikku committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    12f131d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2121855 View commit details
    Browse the repository at this point in the history