Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package.json): htm and preact as dependencies #5

Merged
merged 1 commit into from
Oct 26, 2022
Merged

fix(package.json): htm and preact as dependencies #5

merged 1 commit into from
Oct 26, 2022

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Oct 26, 2022

Since these are not bundled by diagram-js-ui and to be used in production, we should move these from devDependencies to dependencies.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 26, 2022
@smbea smbea requested review from barmac, a team and philippfromme and removed request for a team October 26, 2022 12:15
@fake-join fake-join bot merged commit 4b682fc into main Oct 26, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 26, 2022
@barmac
Copy link
Member

barmac commented Oct 26, 2022

Hmm did you run npm i? Package-lock is left intact

@barmac barmac mentioned this pull request Oct 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

Assignees

@smbea smbea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smbea @barmac