Correct type definitions #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested review from
barmac,
a team and
marstamm
and removed request for
a team
This was referenced Mar 11, 2024
|
I am looking at this right now. |
Effectively this was already a module, all the time.
barmac
reviewed
Mar 12, 2024
package.json
Outdated
| "test": "karma start", | ||
| "dev": "karma start --auto-watch --no-single-run" | ||
| "all": "run-s lint test check-types", | ||
| "check-types": "tsc --noEmit", |
There was a problem hiding this comment.
Since in the opening comment you used noImplicitAny, let's include that in the test. I will add it.
barmac
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we export clear unambiguous types, in the right way. As a result I can
tsctype check anydiagram-js*codebase without this:It also ensures that this exports as an actual module. It was a module all the time, already.