Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize vertical lanes #2067

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Resize vertical lanes #2067

merged 7 commits into from
Jan 22, 2024

Conversation

sombrek
Copy link
Contributor

@sombrek sombrek commented Jan 4, 2024

Closes #2062

This makes resizing by handles and space tool work for vertical pools and lanes.

I just saw that ResizeBehavior.js, SpaceToolBehavior.js and their Spec files have Windows line endings that my IDE didn't make me aware of. They now have Unix-style line endings. Is that acceptable for you?

@nikku nikku requested review from a team, smbea and barmac and removed request for a team January 8, 2024 15:27
@nikku nikku added the needs review Review pending label Jan 8, 2024
@barmac
Copy link
Member

barmac commented Jan 9, 2024

Hi, thanks for this PR! I am looking into this today.

They now have Unix-style line endings. Is that acceptable for you?

I pushed line endings change before your commits to make the review easier. Other than that, I believe it's OK.

@barmac
Copy link
Member

barmac commented Jan 10, 2024

I'm sorry, I didn't manage to have a thorough review of this, but will have a look next week.

@sombrek
Copy link
Contributor Author

sombrek commented Jan 13, 2024

@barmac Don't worry. Thanks for the time you invest in the review.

I used the chance to make an adjustment.
There was one instance where I confused participant and lane in SpaceToolBehavior, I fixed that. The behavior remains the same.
I also added a small set of tests to cover more of my code.

Unfortunately, I created multiple commits. Please provide some squashing support when checking that in.

Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again sorry for the delay. The interaction is mostly good, but there is a difference in the minimal height when shrinking happens from the bottom and from the top:

Screen.Recording.2024-01-19.at.16.50.16.mov

@barmac
Copy link
Member

barmac commented Jan 19, 2024

BTW I've found an edge case which can be reproduced with horizontal participants as well. There is no need to fix this in this PR though. I wouldn't really bother creating an issue for this, too:

Screen.Recording.2024-01-19.at.16.53.10.mov

Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A challenge to solve in the future:

Screen.Recording.2024-01-19.at.17.06.27.mov

@barmac
Copy link
Member

barmac commented Jan 19, 2024

Once again sorry for the delay. The interaction is mostly good, but there is a difference in the minimal height when shrinking happens from the bottom and from the top:

Screen.Recording.2024-01-19.at.16.50.16.mov

This problem can be noticed only if the participant contains child lanes.

@sombrek
Copy link
Contributor Author

sombrek commented Jan 19, 2024

@barmac Thank you very much for your thorough review. Glad you were able to make it.

Once again sorry for the delay. The interaction is mostly good, but there is a difference in the minimal height when shrinking happens from the bottom and from the top:

I can reproduce this also for horizontal pools. I'd be happy if we could treat this as a pre-existing bug and not as a failure in the PR, just like the second issue you discovered.

A challenge to solve in the future:

This is actually on my list already, but out of scope for this PR. I plan to fix add/delete/split separately.

@barmac
Copy link
Member

barmac commented Jan 22, 2024

I can reproduce this also for horizontal pools. I'd be happy if we could treat this as a pre-existing bug and not as a failure in the PR, just like the second issue you discovered.

I was able to reproduce it for horizontal lanes too. Let's keep as is it then.

@barmac barmac merged commit 0a706be into bpmn-io:develop Jan 22, 2024
9 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing Vertical Pools and Lanes
3 participants