Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External label selection outline is incorrect after label is created or modified #2001

Closed
barmac opened this issue Nov 2, 2023 · 1 comment · Fixed by #2003
Closed

External label selection outline is incorrect after label is created or modified #2001

barmac opened this issue Nov 2, 2023 · 1 comment · Fixed by #2003
Assignees
@smbea
Labels
bug Something isn't working

Comments

@barmac
Copy link
Member

barmac commented Nov 2, 2023

Describe the Bug

Given I add an external label (e.g. to an event or a gateway), its selection outline is much bigger than necessary, and it doesn't follow the XML bounds. Also for labels already existing in the diagram, the outline is not updated.

Steps to Reproduce

  1. Create an external label
  2. Select it
Screen.Recording.2023-11-02.at.14.32.03.mov

or

  1. Modify an existing external label
  2. Select it
Screen.Recording.2023-11-02.at.14.35.15.mov

Expected Behavior

It should follow the bounds / label size.

Environment

  • Browser: [e.g. IE 11, Chrome 69]
  • OS: [e.g. Windows 7]
  • Library version: v15.0.0
@barmac barmac added bug Something isn't working ready Ready to be worked on labels Nov 2, 2023
@smbea smbea self-assigned this Nov 2, 2023
smbea added a commit that referenced this issue Nov 2, 2023
@smbea
fix(outline): external label resize
ed3bf2f 
Closes #2001
smbea added a commit that referenced this issue Nov 2, 2023
@smbea
fix(outline): external label resize
d11e7f8 
Closes #2001
@smbea smbea mentioned this issue Nov 2, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Nov 2, 2023
smbea added a commit that referenced this issue Nov 2, 2023
@smbea
fix(outline): external label resize
ee8bb5b 
Closes #2001
smbea added a commit that referenced this issue Nov 2, 2023
@smbea
fix(outline): external label resize
52df3b3 
Closes #2001
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 2, 2023
barmac pushed a commit that referenced this issue Nov 3, 2023
@smbea @barmac
fix(outline): external label resize
c9f4c83 
Closes #2001
@barmac
Copy link
Member Author

barmac commented Nov 3, 2023

Closed via #2003

@barmac barmac closed this as completed Nov 3, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 3, 2023
This was referenced Nov 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(outline): external label resize bpmn-io/bpmn-js
2 participants
@smbea @barmac