-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloud-templates): keep exisiting configuration after apply #661
Conversation
My proposal is that we start to test element template logic against the new APIs ( |
We are already testing against this API, just with some utility around it to ensure the templates are added beforehand: Lines 2273 to 2284 in 522155a
|
Sorry, my bad. What I meant is "move the test to that place" (or consider not to do it). |
I like having it as a separate file from But this is just a slight preference, no strong feelings either way |
Great, in this case let us keep it. I'll just make sure we have some basic coverage in the element template spec, too. |
844b83d
to
7d92c81
Compare
@nikku, how do we want to continue with this PR? From my side, the implementation for keeping configuration C8 is ready for review. Do you want to add the test cases to this PR or is this a separate issue/PR? |
To be confirmed: this PR solved https://camunda.slack.com/archives/C02JLRNQQ05/p1649846975972899 (double taskDefinitions after applying template to configured service task). I will add an explicit test case for this |
57ca456
to
dab3f94
Compare
Added integration tests. This is ready for review now. |
My appologies for not looking into this earlier. I have this PR on my list for tomorrow 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as it should 👍
Found one unrelated visual glitch: #675.
related to #638