Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore canvas focus on properties panel focus change #1094

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Restore canvas focus on properties panel focus change #1094

wants to merge 3 commits into from
+124 −2

Commits on Nov 20, 2024

  1. feat: emit propertiesPanel.focus.changed event 

    This allows components to hook into the properties panel focus state.
    @nikku
    nikku committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7efb4d2 View commit details
    Browse the repository at this point in the history

  2. feat: attempt to restore canvas focus on properties panel blur 

    This ensures our standard editing behavior is preserved,
i.e. when destructive properties panel operations force blur.
    @nikku
    nikku committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3e8bb3b View commit details
    Browse the repository at this point in the history

  3. chore: make properties panel a keyboard trap 

    This ensure properties panel focus is not lost when I mouse down on,
i.e. a label. On the other hand this remains unfocusable through
keyboard navigation. We can consider to change that some day, just
not today 😉.
    @nikku
    nikku committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    22764d0 View commit details
    Browse the repository at this point in the history