fix: set $parent when creating task headers

bpmn-io · Oct 9, 2023 · daeefb2 · daeefb2
1 parent de8f01d
commit daeefb2
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/cloud-element-templates/cmd/ChangeElementTemplateHandler.js b/src/cloud-element-templates/cmd/ChangeElementTemplateHandler.js
@@ -438,7 +438,6 @@ export default class ChangeElementTemplateHandler {
       return newBindingType === 'zeebe:taskHeader';
     });
 
-
     const businessObject = this._getOrCreateExtensionElements(element);
 
     let taskHeaders = findExtension(businessObject, 'zeebe:TaskHeaders');
@@ -461,6 +460,8 @@ export default class ChangeElementTemplateHandler {
     if (!taskHeaders) {
       taskHeaders = bpmnFactory.create('zeebe:TaskHeaders');
 
+      taskHeaders.$parent = businessObject;
+
       commandStack.execute('element.updateModdleProperties', {
         element,
         moddleElement: businessObject,
@@ -502,6 +503,8 @@ export default class ChangeElementTemplateHandler {
       else if (newPropertyValue) {
         const newHeader = createTaskHeader(newBinding, newPropertyValue, bpmnFactory);
 
+        newHeader.$parent = taskHeaders;
+
         commandStack.execute('element.updateModdleProperties', {
           element,
           moddleElement: taskHeaders,

diff --git a/test/spec/cloud-element-templates/cmd/ChangeElementTemplateHandler.spec.js b/test/spec/cloud-element-templates/cmd/ChangeElementTemplateHandler.spec.js
@@ -865,6 +865,13 @@ describe('cloud-element-templates/cmd - ChangeElementTemplateHandler', function(
           expect(taskHeaders).to.exist;
           expect(taskHeaders.get('zeebe:values')).to.have.length(2);
 
+          expect(taskHeaders.$parent)
+            .to.equal(getBusinessObject(task).get('extensionElements'));
+
+          taskHeaders.get('zeebe:values').forEach((value) => {
+            expect(value.$parent).to.equal(taskHeaders);
+          });
+
           expect(taskHeaders.get('zeebe:values')).to.jsonEqual([
             {
               $type: 'zeebe:Header',
@@ -918,6 +925,13 @@ describe('cloud-element-templates/cmd - ChangeElementTemplateHandler', function(
           expect(taskHeaders).to.exist;
           expect(taskHeaders.get('zeebe:values')).to.have.length(2);
 
+          expect(taskHeaders.$parent)
+            .to.equal(getBusinessObject(task).get('extensionElements'));
+
+          taskHeaders.get('zeebe:values').forEach((value) => {
+            expect(value.$parent).to.equal(taskHeaders);
+          });
+
           expect(taskHeaders.get('zeebe:values')).to.jsonEqual([
             {
               $type: 'zeebe:Header',
@@ -949,6 +963,13 @@ describe('cloud-element-templates/cmd - ChangeElementTemplateHandler', function(
           expect(taskHeaders).to.exist;
           expect(taskHeaders.get('zeebe:values')).to.have.length(2);
 
+          expect(taskHeaders.$parent)
+            .to.equal(getBusinessObject(task).get('extensionElements'));
+
+          taskHeaders.get('zeebe:values').forEach((value) => {
+            expect(value.$parent).to.equal(taskHeaders);
+          });
+
           expect(taskHeaders.get('zeebe:values')).to.jsonEqual([
             {
               $type: 'zeebe:Header',