Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of git author, email and check interval #97

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Joibel
Copy link
Contributor

@Joibel Joibel commented Aug 18, 2020

This is a simple change to allow configuration of a few hardcoded git options that I'd like to be able to configure.

10 second pushing is too frequent for my use. I'm pushing to gerrit, which expects each user to register their author details, so I'd like to be able to change those.

@coveralls
Copy link

coveralls commented Aug 25, 2020

Coverage Status

Coverage increased (+0.2%) to 86.552% when pulling 542a0e7 on Joibel:feature/gitconfigopts into d0a1ad8 on bpineau:master.

@Joibel Joibel force-pushed the feature/gitconfigopts branch from 69894c1 to 542a0e7 Compare August 25, 2020 14:47
@bpineau
Copy link
Owner

bpineau commented Nov 29, 2020

All LGTM,
I assume the configurable interval is meant to batch more to reduce noise on high churn surges, is that the case?

Wondering if "commit+push soon if possible, not more than once per user-defined-interval" could be a finer option (as in: archive quickly, with commit timestamps close to the change's timestamp when possible, but batch if needed)? Wdyt?

@Joibel
Copy link
Contributor Author

Joibel commented Nov 29, 2020

I'll rebase this, and split the username stuff out and have a look at your idea. It does make sense. It is about reducing noise, and I actually some more filters for that. I'll see what I can do about that patch too and see what it looks like after that.

@sadortun
Copy link

sadortun commented May 1, 2021

Hi @Joibel, did you made progress on this PR ?

Will this allow us to reduce the numbers of commits/push to something like one per hour/day maximum ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants