DataViews: load the filter toggle as open if there are primary filters (

WordPress#64651) Co-authored-by: oandregal <[email protected]> Co-authored-by: jameskoster <[email protected]>
bph · Aug 31, 2024 · 7753eb9 · 7753eb9
1 parent 26cc3d8
commit 7753eb9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/packages/dataviews/src/components/dataviews/index.tsx b/packages/dataviews/src/components/dataviews/index.tsx
@@ -71,8 +71,6 @@ export default function DataViews< Item >( {
 }: DataViewsProps< Item > ) {
 	const [ selectionState, setSelectionState ] = useState< string[] >( [] );
 	const [ density, setDensity ] = useState< number >( 0 );
-	const [ isShowingFilter, setIsShowingFilter ] =
-		useState< boolean >( false );
 	const isUncontrolled =
 		selectionProperty === undefined || onChangeSelection === undefined;
 	const selection = isUncontrolled ? selectionState : selectionProperty;
@@ -95,6 +93,10 @@ export default function DataViews< Item >( {
 	}, [ selection, data, getItemId ] );
 
 	const filters = useFilters( _fields, view );
+	const [ isShowingFilter, setIsShowingFilter ] = useState< boolean >( () =>
+		( filters || [] ).some( ( filter ) => filter.isPrimary )
+	);
+
 	return (
 		<DataViewsContext.Provider
 			value={ {

diff --git a/test/e2e/specs/site-editor/patterns.spec.js b/test/e2e/specs/site-editor/patterns.spec.js
@@ -149,13 +149,6 @@ test.describe( 'Patterns', () => {
 
 		await expect( patterns.item ).toHaveCount( 3 );
 
-		await patterns.content
-			.getByRole( 'button', {
-				name: 'Toggle filter display',
-				exact: true,
-			} )
-			.click();
-
 		const searchBox = patterns.content.getByRole( 'searchbox', {
 			name: 'Search',
 		} );