Skip to content

Commit

Permalink
Avoid fetch batch for Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
Ben Creech committed Feb 29, 2024
1 parent 331ab60 commit 05c28d3
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ env:
# Don't build PyPy wheels:
CIBW_SKIP: >
pp*
CIBW_MANYLINUX_X86_64_IMAGE: >
manylinux_2_28
jobs:
binary-wheels-standard:
Expand Down
10 changes: 8 additions & 2 deletions helpers/v8_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from shlex import join as shlexjoin
from shutil import copyfile, rmtree
from subprocess import check_call
from sys import platform
from sys import executable, platform

basicConfig()
LOGGER = getLogger(__name__)
Expand Down Expand Up @@ -89,7 +89,13 @@ def ensure_v8_src(revision):

if not isfile(pathjoin(get_workspace_path(), ".gclient")):
makedirs(get_workspace_path(), exist_ok=True)
run("fetch", "--nohooks", "v8", cwd=get_workspace_path())
run(
executable,
pathjoin(get_depot_tools_path(), "fetch.py"),
"--nohooks",
"v8",
cwd=get_workspace_path(),
)

run("gclient", "sync", "--revision", f"v8@{revision}", cwd=get_workspace_path())

Expand Down
7 changes: 6 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
[build-system]
requires = ["hatchling", "hatch-fancy-pypi-readme", "hatch-mkdocs"]
build-backend = "hatchling.build"
requires = [
"hatchling",
"hatch-fancy-pypi-readme",
"hatch-mkdocs",
]

# TODOs:
# make sure alpine and mac and win32 build
Expand Down Expand Up @@ -56,6 +60,7 @@ replacement = '(https://github.com/sqreen/PyMiniRacer/raw/master/data/py_mini_ra
[tool.hatch.envs.default]
dependencies = [
"pytest",
"httplib2", # used by depot_tools
]

[tool.hatch.env.collectors.mkdocs.docs]
Expand Down

0 comments on commit 05c28d3

Please sign in to comment.