Skip to content

Commit

Permalink
[dsccommunity#1163] Added support for RSINSTALLMODE SQL Setup parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
bozho committed Jun 19, 2019
1 parent e8298d5 commit 2c07dff
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
- Changed the logic of how default value of FailoverClusterGroupName is
set since that was preventing the resource to be able to be debugged
([issue #448](https://github.com/PowerShell/SqlServerDsc/issues/448)).
- Added RSInstallMode parameter ([issue #1163](https://github.com/PowerShell/SqlServerDsc/issues/1163)).
- Changes to SqlWindowsFirewall
- Where a version upgrade has changed paths for a database engine, the
existing firewall rule for that instance will be updated rather than
Expand Down
20 changes: 20 additions & 0 deletions DSCResources/MSFT_SqlSetup/MSFT_SqlSetup.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,9 @@ function Get-TargetResource
.PARAMETER RSSvcAccount
Service account for Reporting Services service.
.PARAMETER RSInstallMode
Install mode for Reporting Services.
.PARAMETER ASSvcAccount
Service account for Analysis Services service.
Expand Down Expand Up @@ -894,6 +897,11 @@ function Set-TargetResource
[System.Management.Automation.PSCredential]
$RSSvcAccount,

[Parameter()]
[ValidateSet('SharePointFilesOnlyMode', 'DefaultNativeMode', 'FilesOnlyMode')]
[System.String]
$RSInstallMode,

[Parameter()]
[System.Management.Automation.PSCredential]
$ASSvcAccount,
Expand Down Expand Up @@ -1450,6 +1458,10 @@ function Set-TargetResource
{
$setupArguments += @{ RsSvcStartupType = $RsSvcStartupType}
}
if ($PSBoundParameters.ContainsKey('RSInstallMode'))
{
$setupArguments += @{ RSINSTALLMODE = $RSInstallMode}
}
}

if ($Features.Contains('AS'))
Expand Down Expand Up @@ -1785,6 +1797,9 @@ function Set-TargetResource
.PARAMETER RSSvcAccount
Service account for Reporting Services service.
.PARAMETER RSInstallMode
Install mode for Reporting Services.
.PARAMETER ASSvcAccount
Service account for Analysis Services service.
Expand Down Expand Up @@ -1997,6 +2012,11 @@ function Test-TargetResource
[System.Management.Automation.PSCredential]
$RSSvcAccount,

[Parameter()]
[ValidateSet('SharePointFilesOnlyMode', 'DefaultNativeMode', 'FilesOnlyMode')]
[System.String]
$RSInstallMode,

[Parameter()]
[System.Management.Automation.PSCredential]
$ASSvcAccount,
Expand Down
1 change: 1 addition & 0 deletions DSCResources/MSFT_SqlSetup/MSFT_SqlSetup.schema.mof
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class MSFT_SqlSetup : OMI_BaseResource
[Read, Description("Output username for the Full Text service.")] String FTSvcAccountUsername;
[Write, EmbeddedInstance("MSFT_Credential"), Description("Service account for Reporting Services service.")] String RSSvcAccount;
[Read, Description("Output username for the Reporting Services service.")] String RSSvcAccountUsername;
[Write, Description("Specifies the install mode for SQL Server Report service."), ValueMap{"SharePointFilesOnlyMode", "DefaultNativeMode", "FilesOnlyMode"}, Values{"SharePointFilesOnlyMode", "DefaultNativeMode", "FilesOnlyMode"}] String RSInstallMode;
[Write, EmbeddedInstance("MSFT_Credential"), Description("Service account for Analysis Services service.")] String ASSvcAccount;
[Read, Description("Output username for the Analysis Services service.")] String ASSvcAccountUsername;
[Write, Description("Collation for Analysis Services.")] String ASCollation;
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1893,6 +1893,8 @@ need a '*SVCPASSWORD' argument in the setup arguments.
service.
* **`[PSCredential]` RSSvcAccount** _(Write)_: Service account for Reporting Services
service.
* **`[String]` RSInstallMode** _(Write)_: Reporting Services install mode.
{ SharePointFilesOnlyMode | DefaultNativeMode | FilesOnlyMode }
* **`[PSCredential]` ASSvcAccount** _(Write)_: Service account for Analysis Services
service.
* **`[String]` ASCollation** _(Write)_: Collation for Analysis Services.
Expand Down

0 comments on commit 2c07dff

Please sign in to comment.