Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to docmatic for testing README. #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rasky
Copy link

@rasky rasky commented Dec 25, 2018

Similar to skeptic, but it does not add itself as a build dependency, which means that all downstream users of LZ4 don't need to build skeptic (and all its dependencies).

See budziq/rust-skeptic#60.

Similar to skpetic, but it does not add itself as a build
dependency, which means that all downstream users of LZ4
don't need to build skeptic (and all its dependencies).
See budziq/rust-skeptic#60.
@rasky
Copy link
Author

rasky commented Dec 25, 2018

Travis build has failed for reasons unrelated to this PR.

@rasky
Copy link
Author

rasky commented Jan 9, 2019

ping @bozaro

@jheyens
Copy link
Collaborator

jheyens commented Jan 9, 2019

Sorry for the delay.
First, thanks for your pull request.
Unfortunately, I won't be able to look over this PR until next week. Additionally, I'm in the process of reducing dependencies for this crate and I wanted to drop skeptic completely for v2.0

@rasky
Copy link
Author

rasky commented Jan 9, 2019

Sure! To me, any option is good as long as it doesn't add build dependencies on downstream users like skeptic. Thanks!

@pmarks
Copy link

pmarks commented Apr 24, 2020

@jheyens any chance we could merge this, or an updated version? Having skeptic and it's deps in our build adds quite a lot of extra time. Would be happy to post an update PR. Thanks!

@jheyens
Copy link
Collaborator

jheyens commented Apr 24, 2020

Hi,

Please look at #52

Jens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants