-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade pnpm
so Dependabot can read the lockfile
#1507
Downgrade pnpm
so Dependabot can read the lockfile
#1507
Conversation
pnpm
so Dependabot can read lockfile
pnpm
so Dependabot can read lockfilepnpm
so Dependabot can read the lockfile
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1507 +/- ##
==========================================
+ Coverage 85.59% 85.60% +0.01%
==========================================
Files 232 232
Lines 21710 21708 -2
Branches 1916 1942 +26
==========================================
+ Hits 18582 18583 +1
+ Misses 3088 3085 -3
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fhenrich33
Should we include this in the production deploy on Monday or not @fhenrich33 ? |
Let's hold off and test it a bit more before we pull the trigger to be on the safe side. |
@fhenrich33 looks good (and running locally fine for me), thanks! Just a note that if folks don't downgrade pnpm (using I had hoped that
in .npmrc would at least limit fall out if pnpm 9 is installed (supported since v9.2 to enforce the packageManager version), but I couldn't get it working |
Let's keep a close look at the following PRs to the frontend, and revisit the pnpm issue in the Dependabot tracker. I think it's the best move for now, IMO. @jamescrowley @HaGuesto @pylipp |
Dependabot isn't issuing alerts with
pnpm
v9 lockfile format. See dependabot/dependabot-core#10534Downgrading to latest pre v9 lockfile `pnpm release until v9 is supported: https://github.com/pnpm/pnpm/releases/tag/v8.15.9
Next steps:
Check for updates
after this PR is merged to check for Dependabot security alerts that we missed due to the aforementioned issue.This also address the following Dependabot PRs:
#1506
#1502
#1488
#1485