Fixed #35 and #37

boxuancui · Dec 13, 2016 · cee6c37 · cee6c37
1 parent 7c5898f
commit cee6c37
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -21,7 +21,8 @@ Imports:
 Suggests: testthat,
     covr,
     knitr,
-    rmarkdown
+    rmarkdown,
+    rprojroot
 SystemRequirements: pandoc (>= 1.12.3) - http://pandoc.org
 License: GPL-2
 LazyData: true

diff --git a/NEWS.md b/NEWS.md
@@ -5,10 +5,12 @@
 ### DataExplorer 0.3.0.9000
 #### Bug Fixes
 * [#32](https://github.com/boxuancui/DataExplorer/issues/32): Fixed pandoc requirement error in unit test on cran.
-* [#34](https://github.com/boxuancui/DataExplorer/issues/34): Fixed error message when `quiet` is not supplied. In addition, report directory are printed through `message()` instead of `cat()`. 
+* [#34](https://github.com/boxuancui/DataExplorer/issues/34): Fixed error message when `quiet` is not supplied. In addition, report directory are printed through `message()` instead of `cat()`.
+* [#35](https://github.com/boxuancui/DataExplorer/issues/35): Added **rprojroot** to Suggests.
 
 #### Enhancements
 * [#36](https://github.com/boxuancui/DataExplorer/issues/36): Fixed warnings from data.table in `DropVar`.
+* [#37](https://github.com/boxuancui/DataExplorer/issues/37): Changed all `cat()` to `message()`.
 * Added more examples in README file.
 
 ---

diff --git a/R/BarDiscrete.r b/R/BarDiscrete.r
@@ -35,7 +35,7 @@ BarDiscrete <- function(data, na.rm = TRUE, maxcat = 50) {
   ign_ind <- which(n_cat > maxcat)
   if (length(ign_ind) > 0) {
     set(discrete, j = ign_ind, value = NULL)
-    cat(length(ign_ind), "columns ignored with more than", maxcat, "categories.\n", paste0(names(ign_ind), ": ", n_cat[ign_ind], " categories\n"))
+    message(length(ign_ind), " columns ignored with more than ", maxcat, " categories.\n", paste0(names(ign_ind), ": ", n_cat[ign_ind], " categories\n"))
   }
   ## Get dimension
   n <- nrow(discrete)

diff --git a/R/CorrelationDiscrete.r b/R/CorrelationDiscrete.r
@@ -30,7 +30,7 @@ CorrelationDiscrete <- function(data, maxcat = 20, ...) {
   ign_ind <- which(n_cat > maxcat)
   if (length(ign_ind) > 0) {
     set(discrete, j = ign_ind, value = NULL)
-    cat(length(ign_ind), "columns ignored with more than", maxcat, "categories.\n", paste0(names(ign_ind), ": ", n_cat[ign_ind], " categories\n"))
+    message(length(ign_ind), " columns ignored with more than ", maxcat, " categories.\n", paste0(names(ign_ind), ": ", n_cat[ign_ind], " categories\n"))
   }
   ## Calculate categorical correlation and melt into tidy data format
   discrete[, discrete_id := seq(nrow(discrete))]