This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Don't blow up when Java 8 is installed. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users may have installed Java 8. This module should allow that and do what it can to be useful when that's the case rather than trying to install an older DMG which fails every time e.g.: ``` Puppet (err): Execution of '/usr/sbin/installer -pkg /private/tmp/dmg.tibvCt/Java 7 Update 71.pkg -target /' returned 1: installer: Error - You are trying to install Java 7 Update 71, however Java 8 Update 31 is already installed. Visit java.com/newerversionexists for more information. /Stage[main]/Java/Package[jre-7u71.dmg]/ensure (err): change from absent to present failed: Execution of '/usr/sbin/installer -pkg /private/tmp/dmg.tibvCt/Java 7 Update 71.pkg -target /' returned 1: installer: Error - You are trying to install Java 7 Update 71, however Java 8 Update 31 is already installed. Visit java.com/newerversionexists for more information. ``` This should provide a nice transition to allow Java 8 support to be added to this module without forcing all users to use it yet.
MikeMcQuaid
added a commit
that referenced
this pull request
Mar 9, 2015
Don't blow up when Java 8 is installed.
MikeMcQuaid
added a commit
that referenced
this pull request
Jun 5, 2015
Previously (#54) I handled the case where Java 8 was installed but this just looked at the version for the JDK and tried to install the JRE assuming they had the same version. Instead let's add a `java_jre_version` fact and query that for the JRE and allow installing one or the other depending on the installed version.
MikeMcQuaid
added a commit
that referenced
this pull request
Jun 5, 2015
Previously (#54) I handled the case where Java 8 was installed but this just looked at the version for the JDK and tried to install the JRE assuming they had the same version. Instead let's add a `java_jre_version` fact and query that for the JRE and allow installing one or the other depending on the installed version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users may have installed Java 8. This module should allow that and do what it can to be useful when that's the case rather than trying to install an older DMG which fails every time e.g.:
This should provide a nice transition to allow Java 8 support to be added to this module without forcing all users to use it yet.
CC @dgoodlad @rafaelfranca