Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fonts): update common fonts version #3499

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix(fonts): update common fonts version #3499

merged 1 commit into from
Apr 25, 2024

Conversation

jaknas
Copy link
Contributor

@jaknas jaknas commented Jan 26, 2024

The fonts files itself haven't changed

Changing it to have parity with internal Box changes

@jaknas jaknas requested review from a team as code owners January 26, 2024 16:34
@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jstoffan
jstoffan reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@jstoffan jstoffan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaknas, does this prevent the second set of network calls we see in our first-party apps for these fonts? Isn't the current version in production still 1.0.5?

@jaknas jaknas mentioned this pull request Apr 25, 2024
Merged
@jaknas jaknas force-pushed the update-main-font-version branch from 04861d9 to 7fc8ce8 Compare April 25, 2024 09:17
@jaknas
fix(fonts): update common fonts version
1ac6b59 
the fonts files itself havent changed

changing it to have parity with internal Box changes
@jaknas jaknas force-pushed the update-main-font-version branch from 7fc8ce8 to 1ac6b59 Compare April 25, 2024 09:18
jstoffan
jstoffan approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now that the version in production is the same as the one listed here.

@mergify mergify bot merged commit 870de6d into master Apr 25, 2024
6 checks passed
@mergify mergify bot deleted the update-main-font-version branch April 25, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-in-a-box greg-in-a-box greg-in-a-box approved these changes

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaknas @CLAassistant @jstoffan @greg-in-a-box