feat(preview): Add currentFileVersionId in preview options #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Jul 22, 2020
| @@ -761,6 +761,11 @@ class ContentPreview extends React.PureComponent<Props, State> { | |||
|
|
|||
| if (selectedVersion) { | |||
| setProp(fileOpts, [fileId, 'fileVersionId'], selectedVersion.id); | |||
There was a problem hiding this comment.
It seems like the logic here is the same as what was in box-annotations, just moved up a level. Why isn't it working as-is?
There was a problem hiding this comment.
box-content-preview fetches file version and modifies file.file_version to be the file version that user is viewing. So they're always the same in box-annotations.
There was a problem hiding this comment.
Gotcha. Should we pass down the "current" file version id as a separate property rather than the derived boolean value?
mxiao6
changed the title
jstoffan
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prerequisite of box/box-annotations#542