-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add Annotations bundling changes back #95
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9700a23
Fix: Add Annotations bundling changes back
pramodsum 8edc335
Fix: No longer emit extra 'load' event on 'textlayerrendered'
pramodsum 3b89a6c
Fix: Clean up check for BoxAnnotations in window
pramodsum 52e1e36
Chore: Cleaning up listeners in BaseViewer
pramodsum 2016df9
Chore: Fixes after comments
pramodsum db448d8
Chore: Cleaning up commits from comments
pramodsum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,13 +32,13 @@ class Annotator extends EventEmitter { | |
*/ | ||
constructor(data) { | ||
super(); | ||
this.annotatedElement = data.annotatedElement; | ||
this.annotationService = data.annotationService; | ||
|
||
this.canAnnotate = data.canAnnotate; | ||
this.container = data.container; | ||
this.options = data.options; | ||
this.fileVersionID = data.fileVersionID; | ||
this.locale = data.locale; | ||
this.validationErrorDisplayed = false; | ||
|
||
this.notification = new Notification(this.annotatedElement); | ||
} | ||
|
||
/** | ||
|
@@ -65,8 +65,29 @@ class Annotator extends EventEmitter { | |
* @return {void} | ||
*/ | ||
init() { | ||
this.annotatedElement = this.getAnnotatedEl(this.container); | ||
this.annotationService = this.initAnnotationService(this.options); | ||
this.notification = new Notification(this.annotatedElement); | ||
|
||
this.setScale(1); | ||
this.setupAnnotations(); | ||
this.showAnnotations(); | ||
} | ||
|
||
/** | ||
* Initializes the Annotation Service with appropriate options | ||
* | ||
* @param {Object} options - Options passed from the viewer to the annotator | ||
* @return {AnnotationService} AnnotationService instance | ||
*/ | ||
initAnnotationService(options) { | ||
const { apiHost, fileId, token } = options; | ||
return new AnnotationService({ | ||
apiHost, | ||
fileId, | ||
token, | ||
canAnnotate: this.canAnnotate | ||
}); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think breaking this out into a function is super valuable. |
||
|
||
/** | ||
|
@@ -219,6 +240,16 @@ class Annotator extends EventEmitter { | |
createAnnotationThread(annotations, location, type) {} | ||
/* eslint-enable no-unused-vars */ | ||
|
||
/** | ||
* Must be implemented to determine the annotated element in the viewer. | ||
* | ||
* @param {HTMLElement} containerEl - Container element for the viewer | ||
* @return {HTMLElement} Annotated element in the viewer | ||
*/ | ||
/* eslint-disable no-unused-vars */ | ||
getAnnotatedEl(containerEl) {} | ||
/* eslint-enable no-unused-vars */ | ||
|
||
//-------------------------------------------------------------------------- | ||
// Protected | ||
//-------------------------------------------------------------------------- | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
import DocAnnotator from './doc/DocAnnotator'; | ||
import ImageAnnotator from './image/ImageAnnotator'; | ||
|
||
const ANNOTATORS = [ | ||
{ | ||
NAME: 'Document', | ||
CONSTRUCTOR: DocAnnotator, | ||
VIEWER: ['Document', 'Presentation'], | ||
TYPE: ['point', 'highlight'] | ||
}, | ||
{ | ||
NAME: 'Image', | ||
CONSTRUCTOR: ImageAnnotator, | ||
VIEWER: ['Image'], | ||
TYPE: ['point'] | ||
} | ||
]; | ||
|
||
class BoxAnnotations { | ||
|
||
/** | ||
* [constructor] | ||
* | ||
* @return {BoxAnnotations} BoxAnnotations instance | ||
*/ | ||
constructor() { | ||
this.annotators = ANNOTATORS; | ||
} | ||
|
||
/** | ||
* Returns the available annotators | ||
* | ||
* @return {Array} List of supported annotators | ||
*/ | ||
getAnnotators() { | ||
return Array.isArray(this.annotators) ? this.annotators : []; | ||
} | ||
|
||
/** | ||
* Chooses a annotator based on file extension. | ||
* | ||
* @param {Object} file - Box file | ||
* @param {Array} [disabledAnnotators] - List of disabled annotators | ||
* @return {Object} The annotator to use | ||
*/ | ||
determineAnnotator(viewer, disabledAnnotators = []) { | ||
return this.annotators.find((annotator) => | ||
!(disabledAnnotators.includes(annotator.NAME)) && annotator.VIEWER.includes(viewer) | ||
); | ||
} | ||
} | ||
|
||
global.BoxAnnotations = BoxAnnotations; | ||
export default BoxAnnotations; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.